Skip to content

Sync our pr template to match serving.#357

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:sync-pr-temp
Aug 14, 2018
Merged

Sync our pr template to match serving.#357
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:sync-pr-temp

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

Use what serving uses.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/assign @evankanderson

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@knative-prow-robot knative-prow-robot merged commit 71dcedc into knative:master Aug 14, 2018
matzew added a commit to matzew/eventing that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants