Skip to content

[WIP] Add descriptions for Trigger.#3573

Closed
vaikas wants to merge 1 commit into
knative:masterfrom
vaikas:eventing-descriptions
Closed

[WIP] Add descriptions for Trigger.#3573
vaikas wants to merge 1 commit into
knative:masterfrom
vaikas:eventing-descriptions

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jul 13, 2020

Addresses #3054

Proposed Changes

  • Add an openapi schema and in particular, descriptions to the schema.

Release Note

- 🎁 Add new feature
Add openapi schema for Trigger, so kubectl explain now works.

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 13, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Jul 23, 2020

/test pull-knative-eventing-integration-tests

@aliok
Copy link
Copy Markdown
Member

aliok commented Aug 6, 2020

/retest

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@vaikas: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-conformance-tests a9f7bd6 link /test pull-knative-eventing-conformance-tests
pull-knative-eventing-integration-tests a9f7bd6 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers_using_v1beta1_trigger
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_deprecated_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestTriggerDependencyAnnotation
test/e2e.TestEventTransformationForTriggerV1Beta1BrokerV1/Channel-messaging.knative.dev/v1beta1
test/e2e.TestEventTransformationForTriggerV1Beta1BrokerV1/InMemoryChannel-messaging.knative.dev/v1
test/e2e.TestEventTransformationForTriggerV1Beta1BrokerV1/Channel-messaging.knative.dev/v1

and 65 more.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@vaikas: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2020
@pierDipi
Copy link
Copy Markdown
Member

Done #3845
/close

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@pierDipi: Closed this PR.

Details

In response to this:

Done #3845
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants