SinkBinding v1beta1 Reconciler & E2E test#3577
Merged
Merged
Conversation
knative-prow-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
area/test-and-release
# Conflicts: # go.mod # go.sum # vendor/knative.dev/pkg/apis/duck/v1/addressable_types.go # vendor/knative.dev/pkg/apis/duck/v1/podspec_types.go # vendor/knative.dev/pkg/apis/duck/v1/source_types.go # vendor/knative.dev/pkg/apis/duck/v1/status_types.go # vendor/knative.dev/pkg/apis/duck/v1beta1/addressable_types.go # vendor/knative.dev/pkg/apis/duck/v1beta1/source_types.go # vendor/knative.dev/pkg/apis/duck/v1beta1/status_types.go # vendor/modules.txt
knative-prow-robot
added
the
needs-rebase
might need to do it together with container source
knative-prow-robot
removed
the
needs-rebase
knative-prow-robot
added
size/XL
|
The following is the coverage report on the affected files.
|
# Conflicts: # pkg/apis/sources/v1alpha1/sinkbinding_conversion.go # pkg/apis/sources/v1alpha2/sinkbinding_conversion.go # vendor/knative.dev/pkg/kflag/doc.go
knative-prow-robot
added
size/L
nachocano
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/assign @vaikas |
Contributor
Author
|
hmmm |
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests: |
Contributor
Author
|
/retest |
Contributor
Author
|
ping |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #3544
Proposed Changes
Missing to flip the storage bit, will do after this one gets merged
Release Note
Docs
knative/docs#2663