Skip to content

Decoupled fanout config from ducktypes#3703

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:issues/3702
Jul 27, 2020
Merged

Decoupled fanout config from ducktypes#3703
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:issues/3702

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jul 24, 2020 •
edited
Loading

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #3702

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 24, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jul 24, 2020

/assign @aliok

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jul 24, 2020

/retest

aliok
aliok approved these changes Jul 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

It looks good, but there are some parts that I don't understand.
Holding for others to have a look

cc @vaikas

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 24, 2020
@slinkydeveloper
Decoupled fanout config from ducktypes
b76bbf9 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Marshal/Unmarshal code
09e1999 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Pruned all json code
9eb3a5e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jul 27, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/channel/fanout/fanout_message_handler.go 89.1% 70.0% -19.1
pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go 77.1% 74.2% -2.9

aliok
aliok approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks! let's merge this to unblock knative/eventing-contrib#1397

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Copy Markdown
Member

aliok commented Jul 27, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jul 27, 2020

/retest

1 similar comment
@aliok
Copy link
Copy Markdown
Member

aliok commented Jul 27, 2020

/retest

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 27, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jul 27, 2020

/retest

1 similar comment
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jul 27, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit c65c9de into knative:master Jul 27, 2020
@slinkydeveloper slinkydeveloper deleted the issues/3702 branch July 27, 2020 16:05
@aliok
Copy link
Copy Markdown
Member

aliok commented Jul 28, 2020

Merged but open?

@aliok
Copy link
Copy Markdown
Member

aliok commented Jul 28, 2020

Ah, no Github flake

@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok approved these changes

@aslom aslom Awaiting requested review from aslom

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@aliok aliok

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate fanout message handler to duck v1

6 participants

@slinkydeveloper @knative-metrics-robot @knative-prow-robot @aliok @knative-test-reporter-robot @googlebot