Skip to content

Run conformance tests in a separate Prow job#3719

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
chizhg:conformance-test-flow
Jul 28, 2020
Merged

Run conformance tests in a separate Prow job#3719
knative-prow-robot merged 2 commits into
knative:masterfrom
chizhg:conformance-test-flow

Conversation

@chizhg
Copy link
Copy Markdown
Contributor

@chizhg chizhg commented Jul 25, 2020

Proposed Changes

  • Eventing integration tests Prow job is now taking more than 40 mins, and the time will continue growing as more and more tests are added. So unless we really want to run conformance and e2e tests together, IMO it's better to run them in two separate Prow jobs, which could help reduce the presubmit turnaround time.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 25, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 25, 2020
@chizhg chizhg mentioned this pull request Jul 25, 2020
Merged
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2020
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jul 25, 2020

/cc @vaikas

aliok
aliok approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I think this makes a lot of sense!

@aliok
Copy link
Copy Markdown
Member

aliok commented Jul 27, 2020

@chizhg Can you have a look at eventing-contrib as well? We're adding the same conformance tests over there too.
You think it is necessary to do the same change over there?

grantr
grantr approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 27, 2020

Thanks for doing this!
/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, chizhg, grantr, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jul 27, 2020

/retest

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 27, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers_using_v1beta1_trigger
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
test/e2e.TestParallelV1
test/e2e.TestParallelV1/InMemoryChannel-messaging.knative.dev/v1beta1

@nachocano nachocano mentioned this pull request Jul 27, 2020
Closed
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jul 27, 2020

/retest

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jul 28, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot knative-prow-robot merged commit 3730dee into knative:master Jul 28, 2020
@vaikas vaikas mentioned this pull request Aug 21, 2020
Merged
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok approved these changes

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

@vaikas vaikas Awaiting requested review from vaikas

+1 more reviewer

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@vaikas vaikas

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chizhg @aliok @vaikas @knative-prow-robot @knative-test-reporter-robot @pierDipi @grantr @googlebot