Skip to content

reenable HA for mtping#3746

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
lionelvillard:i3571
Jul 28, 2020
Merged

reenable HA for mtping#3746
knative-prow-robot merged 2 commits intoknative:masterfrom
lionelvillard:i3571

Conversation

@lionelvillard
Copy link
Copy Markdown
Contributor

Fixes #3571

Proposed Changes

  • Enable HA for mtping
  • Provide a way to disable HA using --disable-ha flag.

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 28, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/v2/main.go 54.8% 56.4% 1.6

@aslom
Copy link
Copy Markdown
Contributor

aslom commented Jul 28, 2020

/assign

@aslom
Copy link
Copy Markdown
Contributor

aslom commented Jul 28, 2020

Ability to disable HA from CLI looks like good idea.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot knative-prow-robot merged commit a96fed1 into knative:master Jul 28, 2020
@lionelvillard lionelvillard deleted the i3571 branch September 3, 2020 15:29
@lionelvillard lionelvillard restored the i3571 branch September 3, 2020 15:43
@lionelvillard lionelvillard deleted the i3571 branch September 3, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mtping should enable the adapter leader election functionality.

5 participants