Skip to content

put the waiting of kresources in a retry loop for webhook failures #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jul 29, 2020
Merged

put the waiting of kresources in a retry loop for webhook failures #3751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/lib/operation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,14 @@ func (c *Client) WaitForResourcesReadyOrFail(typemeta *metav1.TypeMeta) {
// WaitForAllTestResourcesReady waits until all test resources in the namespace are Ready.
func (c *Client) WaitForAllTestResourcesReady() error {
// wait for all Knative resources created in this test to become ready.
if err := c.Tracker.WaitForKResourcesReady(); err != nil {
err := c.RetryWebhookErrors(func(attempts int) (err error) {
e := c.Tracker.WaitForKResourcesReady()
if e != nil {
c.T.Logf("Failed to get all KResources ready %v", e)
}
return e
})
if err != nil {
return err
}
// Explicitly wait for all pods that were created directly by this test to become ready.
Expand Down