Fix env var len check in gh feedlet#377
Merged
knative-prow-robot merged 1 commit intoAug 20, 2018
Merged
Conversation
The logic is inverted when we are checking for existence of FEED_NAMESPACE and other env vars in the gihub source feedlet - we are asserting len != 0 rather than len == 0.
knative-prow-robot
added
the
size/XS
Contributor
Author
|
/test pull-knative-eventing-integration-tests |
Contributor
|
/lgtm Thanks! |
Contributor
|
/assign @evankanderson |
|
|
||
| feedNamespace := os.Getenv(sources.FeedNamespaceKey) | ||
| if len(feedNamespace) != 0 { | ||
| if len(feedNamespace) == 0 { |
Member
There was a problem hiding this comment.
I have a slight preference for comparing with empty string here, as it seems less likely to produce these sorts of errors.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, greghaynes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Merged
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Oct 24, 2023
knative#377) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The logic is inverted when we are checking for existence of
FEED_NAMESPACE and other env vars in the gihub source feedlet - we are
asserting len != 0 rather than len == 0.
Release Note