Skip to content

[WIP] subscription and sinkbinding to have a description via 'kubectl explain'#3835

Closed
nlopezgi wants to merge 2 commits into
knative:masterfrom
nlopezgi:issue-3054-3
Closed

[WIP] subscription and sinkbinding to have a description via 'kubectl explain'#3835
nlopezgi wants to merge 2 commits into
knative:masterfrom
nlopezgi:issue-3054-3

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi commented Aug 13, 2020

Part of #3054

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 13, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlopezgi
To complete the pull request process, please assign nachocano
You can assign the PR to them by writing /assign @nachocano in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2020

@nlopezgi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-conformance-tests 928eb17 link /test pull-knative-eventing-conformance-tests
pull-knative-eventing-integration-tests 928eb17 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 13, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestSinkBindingV1Beta1Deployment
test/e2e.TestSinkBindingDeployment
test/e2e.TestSinkBindingV1Alpha2Deployment

@nlopezgi nlopezgi changed the title subscription and sinkbinding to have a description via 'kubectl explain' [WIP] subscription and sinkbinding to have a description via 'kubectl explain' Aug 14, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
This was referenced Aug 14, 2020
Merged
Merged
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Aug 14, 2020

superseded by the two prs linked above

@nlopezgi nlopezgi closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lberk lberk Awaiting requested review from lberk

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nlopezgi @knative-prow-robot @knative-test-reporter-robot @googlebot