Skip to content

Log dispatch errors in stub bus #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Aug 30, 2018
+9 −1
Merged

Log dispatch errors in stub bus #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/buses/stub/bus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func (b *StubBus) addChannel(channelRef buses.ChannelReference, parameters buses
b.channels[channelRef] = &stubChannel{
parameters: parameters,
subscriptions: make(map[buses.SubscriptionReference]*stubSubscription),
logger: b.logger,
}
}
}
Expand All @@ -98,11 +99,18 @@ type stubChannel struct {
channelRef buses.ChannelReference
parameters buses.ResolvedParameters
subscriptions map[buses.SubscriptionReference]*stubSubscription

logger *zap.SugaredLogger
}

func (c *stubChannel) receiveMessage(message *buses.Message) {
for _, stubSubscription := range c.subscriptions {
go stubSubscription.dispatchMessage(message)
go func() {
err := stubSubscription.dispatchMessage(message)
if err != nil {
c.logger.Warnf("Failed to dispatch message: %v", err)
}
}()
}
}

Expand Down