Skip to content

First attempt to explain how config works in receive adapters#3896

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
lionelvillard:doc-ra-config
Aug 31, 2020
Merged

First attempt to explain how config works in receive adapters#3896
knative-prow-robot merged 2 commits into
knative:masterfrom
lionelvillard:doc-ra-config

Conversation

@lionelvillard
Copy link
Copy Markdown
Contributor

@lionelvillard lionelvillard commented Aug 20, 2020

Proposed Changes

  • First attempt to explain how config works in receive adapters. Not meant to be too extensive yet

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 20, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer

@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Aug 20, 2020

This fails due to:

CONT  TestBrokerV1Beta1DataPlaneConsumer
    event_info_store.go:245: Timeout waiting for at least 2 matches.
        Error: FAIL MATCHING: saw 0/2 matching events.

How reliable is port-forward?:

monitoring.go:78: Executing command: kubectl port-forward second-logger-pod 47736:8392 -n test-broker-v1-beta1-data-plane-consumer-rcq7z
    monitoring.go:71: running second-logger-pod port-forward in background, pid = 50982

@vaikas

@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Aug 20, 2020

/test pull-knative-eventing-conformance-tests

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 21, 2020

port forwarding reliability is something that @slinkydeveloper was looking at
#3570

@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Aug 27, 2020

/test pull-knative-eventing-conformance-tests

aliok
aliok reviewed Aug 31, 2020
View reviewed changes
Comment thread docs/source/receive-adapter.md Outdated
@aliok
Copy link
Copy Markdown
Member

aliok commented Aug 31, 2020

/assign

aliok
aliok approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Thanks for this doc work. I only have a small comment.
Feel free to unhold.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Aug 31, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
aliok
aliok approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c91c4ff into knative:master Aug 31, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok approved these changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@aliok aliok

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lionelvillard @knative-test-reporter-robot @vaikas @aliok @knative-prow-robot @googlebot