Skip to content

Make eventing.* v1 resources the stored version#3923

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing-storage-v1
Aug 25, 2020
Merged

Make eventing.* v1 resources the stored version#3923
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing-storage-v1

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Aug 25, 2020 •
edited
Loading

Fixes #3579

Proposed Changes

  • Make eventing.* v1 resources the stored version
  • Add those resources to migration job

Release Note


- 🧽 Update or clean up current behavior
Change storage versions of eventing.* resources from v1beta1 to v1:
          - "brokers.eventing.knative.dev"
          - "triggers.eventing.knative.dev"

action required: You must run pre-install job prior to upgrading to get eventing.* resources to v1 API.

Docs

No docs change necessary. The content at https://knative.dev/docs/install/upgrade-installation/#run-pre-install-tools-before-upgrade is good enough

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2020
@aliok aliok mentioned this pull request Aug 25, 2020
Closed
@nlopezgi
Copy link
Copy Markdown
Contributor

nlopezgi commented Aug 25, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
matzew
matzew approved these changes Aug 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@aliok aliok mentioned this pull request Aug 25, 2020
Merged
@knative-prow-robot knative-prow-robot merged commit ad20475 into knative:master Aug 25, 2020
@aliok aliok deleted the eventing-storage-v1 branch August 25, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@grantr grantr Awaiting requested review from grantr

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@matzew matzew

@nlopezgi nlopezgi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make eventing.* v1 resources the stored version

5 participants

@aliok @nlopezgi @knative-prow-robot @matzew @googlebot