Skip to content

Change storage to v1 for subscriptions#3936

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:subscription-storage-v1
Aug 27, 2020
Merged

Change storage to v1 for subscriptions#3936
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:subscription-storage-v1

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Aug 27, 2020

Fixes #3929

Proposed Changes

  • Store subscriptions as v1
  • Migration job config

Release Note

- 🧽 Update or clean up current behavior
Change storage version of remaining messaging.* resources from v1beta1 to v1:
          - "subscriptions.messaging.knative.dev"

action required: You must run pre-install job prior to upgrading to get messaging.* resources to v1 API.

Docs

No docs change necessary. The content at https://knative.dev/docs/install/upgrade-installation/#run-pre-install-tools-before-upgrade is good enough

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 27, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2020
@aliok aliok force-pushed the subscription-storage-v1 branch from c942533 to a3769c6 Compare August 27, 2020 10:08
Comment thread config/pre-install/v0.18.0/subscription.yaml
Comment thread config/pre-install/v0.18.0/subscription.yaml
Comment thread config/pre-install/v0.18.0/subscription.yaml
@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-08-27 10:26:25.177 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-conformance-tests

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@knative-prow-robot knative-prow-robot merged commit b36e8ad into knative:master Aug 27, 2020
@aliok aliok deleted the subscription-storage-v1 branch August 27, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage version change for subscriptions.messaging.dev

6 participants