Vendor the test-infra scripts#394
Merged
Merged
Conversation
* shared scripts from test-infra live in //vendor/github.com/knative/test-infra/scripts; * update `update-deps.sh` to keep only the scripts folder; * all bash scripts were updated to use the vendored scripts; Bonus: use `check_licenses()` from `library.sh`, this will transparently handle the installation of `dep-collector` (if necessary). Part of knative/test-infra#30.
knative-prow-robot
added
the
size/XL
OS X's `mktemp` has no `-p` flag.
Member
|
/lgtm Bonus: This removes the Docker client dep from the contributor DevX 🎉 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Jan 14, 2020
Adding prep for 0.12 operator
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Oct 24, 2023
…native#394) * Apply vendor patches on make generate-release * Align create-release-branch --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-deps.shto keep only the scripts folder;Bonus: use
check_licenses()fromlibrary.sh, this will transparently handle the installation ofdep-collector(if necessary).Part of knative/test-infra#30.