Make PingSource v1beta1 the stored version and add a migration tool

[aavarghese]

Signed-off-by: Ansu Varghese avarghese@us.ibm.com

#3886

[knative-prow-robot]

Hi @aavarghese. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lionelvillard]

/ok-to-test

[aliok]

Didn't see the WIP and added some comments.
Let me have another look later.

[aavarghese]

/retest

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

---

Unable to apply comments to the following files:

• pkg/reconciler/pingsource/resources/receive_adapter_test.go
• pkg/reconciler/testing/pingsource.go

[aavarghese]

/retest

[aliok]

/assign

[aliok]

Why is this deleted? I don't have a lot of context, sorry if I am asking something silly.

[aavarghese]

@aliok For pingsource v1beta1 lifecycle, the PingSourceConditionValidSchedule
condition was removed, along with others (#3607). MarkSchedule() in v1alpha2 also has a comment // TODO: this is a bad method name, change it. . Don't know what the plan is here cc: @lionelvillard

[lionelvillard]

yes this is a good change! The schedule is validated by the webhook so no need for a condition.

[aliok]

All good, thanks

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pingsource/pingsource.go	70.0%	69.4%	-0.6

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-conformance-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1ControlPlane/MTChannelBasedBroker-eventing.knative.dev/v1beta1/Ready_Trigger_V1Beta1_includes_status.subscriber_Uri
test/conformance.TestBrokerV1Beta1ControlPlane/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1ControlPlane

[lionelvillard]

/test pull-knative-eventing-conformance-tests

[aavarghese]

Tests have all passed. Submitting for final reviews/approvals....

[lionelvillard]

/approve

@aliok for LGTM

[aliok]

/lgtm
/approve

Thanks!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment