Skip to content

Enqueue Triggers on Broker changes without Tracker#3966

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:enqueue-triggers-on-br-changes
Aug 31, 2020
Merged

Enqueue Triggers on Broker changes without Tracker#3966
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:enqueue-triggers-on-br-changes

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Aug 30, 2020 •
edited
Loading

Addresses knative/eventing-contrib#1424 and subtests.

Proposed Changes

  • Enqueue Triggers on Broker changes without Tracker

Release Note

- 🐛 Fix bug
Trigger reconciler correctly reconciles Triggers during parallel updates of the Trigger and the referenced Broker.

@pierDipi
Enqueue Triggers on Broker changes
eef9a6c 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Aug 30, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtbroker/trigger/controller.go 100.0% 66.7% -33.3
pkg/reconciler/mtbroker/trigger/trigger.go 78.6% 78.2% -0.4

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 30, 2020

/cc @vaikas

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 30, 2020

Worked, retesting
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

1 similar comment
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 30, 2020

Worked, retesting
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

@pierDipi pierDipi changed the title [WIP] Enqueue Triggers on Broker changes without Tracker Enqueue Triggers on Broker changes without Tracker Aug 31, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Aug 31, 2020

/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 31, 2020

We got 10/10 successful runs in eventing-contrib using this patch, see knative/eventing-contrib#1517 and PR history https://prow.knative.dev/pr-history/?org=knative&repo=eventing-contrib&pr=1517

@matzew
Copy link
Copy Markdown
Member

matzew commented Aug 31, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
This was referenced Aug 31, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@knative-prow-robot knative-prow-robot merged commit 0be90fa into knative:master Aug 31, 2020
@pierDipi pierDipi mentioned this pull request Aug 31, 2020
Merged
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 31, 2020
@pierDipi @matzew
Enqueue Triggers on Broker changes (knative#3966)
dd0ded1 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Aug 31, 2020
@pierDipi
Enqueue Triggers on Broker changes (knative#3966)
fdb60c0 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request Aug 31, 2020
@pierDipi
Enqueue Triggers on Broker changes (#3966) (#3968)
4051c5d 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Aug 31, 2020
@matzew @pierDipi
Enqueue Triggers on Broker changes (knative#3966) (#800)
851c2aa 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
n3wscott
n3wscott reviewed Sep 1, 2020
View reviewed changes
Comment thread pkg/reconciler/mtbroker/trigger/controller.go
@@ -66,6 +71,28 @@ func NewController(

triggerInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also filter the trigger changes based on which broker it points to.

Copy link
Copy Markdown
Contributor

@vaikas vaikas Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n3wscott can you explain more what you mean? doesn't the label selector filter by the broker it points to? Or am I misunderstanding.

Copy link
Copy Markdown
Contributor

@n3wscott n3wscott Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broker impl only needs triggers for brokers. We filter broker changes for triggers but we should do the other side too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslom aslom Awaiting requested review from aslom

@grantr grantr Awaiting requested review from grantr

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pierDipi @knative-metrics-robot @matzew @knative-prow-robot @vaikas @n3wscott @googlebot