Skip to content

fixed up the event type webhook validation.#399

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:webhooks_eventtype
Aug 29, 2018
Merged

fixed up the event type webhook validation.#399
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:webhooks_eventtype

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott commented Aug 28, 2018

Follow-up to: #352

Proposed Changes

  • Finish validation for ClusterEventType and EventType.

Release Note

[Cluster]EventType.spec.[cluster]EventSource is now validated to be immutable.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 28, 2018

/assign @vaikas-google

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Aug 28, 2018

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/apis/feeds/v1alpha1/cluster_event_type_validation.go 0.0% 78.6% 78.6
pkg/apis/feeds/v1alpha1/common_event_type_validation.go 0.0% 100.0% 100.0
pkg/apis/feeds/v1alpha1/event_type_validation.go 0.0% 78.6% 78.6

@adamharwayne
Copy link
Copy Markdown
Contributor

adamharwayne commented Aug 28, 2018

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 29, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@knative-prow-robot knative-prow-robot merged commit 49533ae into knative:master Aug 29, 2018
matzew pushed a commit to matzew/eventing that referenced this pull request Dec 7, 2023
@mgencur
Merge pull request knative#399 from mgencur/chmod_codegen_1.12
31b2733 
[release-v1.12] Patch for chmod on codegen files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@inlined inlined Awaiting requested review from inlined

Assignees

@adamharwayne adamharwayne

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n3wscott @knative-metrics-robot @adamharwayne @vaikas @knative-prow-robot