Skip to content

remove unused triggerlister #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Sep 3, 2020
Merged

remove unused triggerlister #3996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/reconciler/mtbroker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import (
messagingv1 "knative.dev/eventing/pkg/apis/messaging/v1"
clientset "knative.dev/eventing/pkg/client/clientset/versioned"
brokerreconciler "knative.dev/eventing/pkg/client/injection/reconciler/eventing/v1/broker"
eventinglisters "knative.dev/eventing/pkg/client/listers/eventing/v1"
messaginglisters "knative.dev/eventing/pkg/client/listers/messaging/v1"
"knative.dev/eventing/pkg/duck"
"knative.dev/eventing/pkg/reconciler/mtbroker/resources"
Expand All @@ -57,7 +56,6 @@ type Reconciler struct {
// listers index properties about resources
endpointsLister corev1listers.EndpointsLister
subscriptionLister messaginglisters.SubscriptionLister
triggerLister eventinglisters.TriggerLister
configmapLister corev1listers.ConfigMapLister

channelableTracker duck.ListableTracker
Expand Down
2 changes: 0 additions & 2 deletions pkg/reconciler/mtbroker/broker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,6 @@ func TestReconcile(t *testing.T) {
eventingClientSet: fakeeventingclient.Get(ctx),
dynamicClientSet: fakedynamicclient.Get(ctx),
subscriptionLister: listers.GetSubscriptionLister(),
triggerLister: listers.GetTriggerLister(),

endpointsLister: listers.GetEndpointsLister(),
configmapLister: listers.GetConfigMapLister(),
kresourceTracker: duck.NewListableTracker(ctx, conditions.Get, func(types.NamespacedName) {}, 0),
Expand Down
3 changes: 0 additions & 3 deletions pkg/reconciler/mtbroker/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
eventingclient "knative.dev/eventing/pkg/client/injection/client"
"knative.dev/eventing/pkg/client/injection/ducks/duck/v1/channelable"
brokerinformer "knative.dev/eventing/pkg/client/injection/informers/eventing/v1/broker"
triggerinformer "knative.dev/eventing/pkg/client/injection/informers/eventing/v1/trigger"
subscriptioninformer "knative.dev/eventing/pkg/client/injection/informers/messaging/v1/subscription"
brokerreconciler "knative.dev/eventing/pkg/client/injection/reconciler/eventing/v1/broker"
"knative.dev/eventing/pkg/duck"
Expand Down Expand Up @@ -60,7 +59,6 @@ func NewController(
) *controller.Impl {
logger := logging.FromContext(ctx)
brokerInformer := brokerinformer.Get(ctx)
triggerInformer := triggerinformer.Get(ctx)
subscriptionInformer := subscriptioninformer.Get(ctx)
endpointsInformer := endpointsinformer.Get(ctx)
configmapInformer := configmapinformer.Get(ctx)
Expand All @@ -77,7 +75,6 @@ func NewController(
dynamicClientSet: dynamicclient.Get(ctx),
endpointsLister: endpointsInformer.Lister(),
subscriptionLister: subscriptionInformer.Lister(),
triggerLister: triggerInformer.Lister(),
brokerClass: eventing.MTChannelBrokerClassValue,
configmapLister: configmapInformer.Lister(),
}
Expand Down