Skip to content

Validate and default feeds.#401

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:webhooks_feed
Aug 29, 2018
Merged

Validate and default feeds.#401
knative-prow-robot merged 1 commit into
knative:masterfrom
n3wscott:webhooks_feed

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

Relates to #352

Proposed Changes

  • Update validation for Feeds
  • Add default service account.

Release Note

"default" will be defaulted for Feed.spec.serviceAccount if none is provided.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/assign @vaikas-google

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/apis/feeds/v1alpha1/feed_defaults.go 0.0% 100.0% 100.0
pkg/apis/feeds/v1alpha1/feed_validation.go 66.7% 86.4% 19.7

@adamharwayne
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 29, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@knative-prow-robot knative-prow-robot merged commit 56618d4 into knative:master Aug 29, 2018
mgencur pushed a commit to mgencur/eventing that referenced this pull request Oct 26, 2023
…atures.yaml configmap (knative#7385) (knative#401)

* Applying partial features.yaml configmap overrides default values



* Add all FF and test enabled by default feature



* Remove OIDC auth FF



---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants