Skip to content

Remove 'master' where not necessary and add tracking issues. #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Sep 9, 2020
Merged

Remove 'master' where not necessary and add tracking issues. #4022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/adapter/v2/cloudevents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type mockReporter struct {
}

var (
fakeMasterURL = "test-source"
fakeURL = "test-source"
)

func (r *mockReporter) ReportEventCount(args *source.ReportArgs, responseCode int) error {
Expand Down Expand Up @@ -70,7 +70,7 @@ func TestNewCloudEventsClient_send(t *testing.T) {
}
for n, tc := range testCases {
t.Run(n, func(t *testing.T) {
ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{})
ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{})
if err != nil {
t.Fail()
}
Expand Down Expand Up @@ -125,7 +125,7 @@ func TestNewCloudEventsClient_request(t *testing.T) {
}
for n, tc := range testCases {
t.Run(n, func(t *testing.T) {
ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{})
ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{})
if err != nil {
t.Fail()
}
Expand Down
2 changes: 1 addition & 1 deletion test/lib/nodes/nodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (n *NodesClient) RandomWorkerNode() (*corev1.Node, error) {
" it must be a worker (Minikube, CRC)", node.Name)
return &node, nil
} else {
role := "master"
role := "master" // see https://github.com/kubernetes/kubeadm/issues/2200 for replacement.
n.logger.Infof("Filtering %d nodes, to not contain role: %s", nodesCount, role)
workers := FilterOutByRole(nodes.Items, role)
n.logger.Infof("Found %d worker(s)", len(workers))
Expand Down