Skip to content

Rename [bus|channel|subscription]Ref#406

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
scothis:buses-refs-rename
Sep 11, 2018
Merged

Rename [bus|channel|subscription]Ref#406
knative-prow-robot merged 2 commits into
knative:masterfrom
scothis:buses-refs-rename

Conversation

@scothis
Copy link
Copy Markdown
Contributor

@scothis scothis commented Aug 30, 2018

Follow-up from #382 (comment)

Release Note

NONE

/assign @n3wscott

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 30, 2018
@n3wscott
Copy link
Copy Markdown
Contributor

looks more and more like golang!

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2018
@n3wscott
Copy link
Copy Markdown
Contributor

Ville for approval:

/assign @vaikas-google

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Sep 11, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scothis, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@knative-prow-robot knative-prow-robot merged commit 56542fa into knative:master Sep 11, 2018
@scothis scothis deleted the buses-refs-rename branch September 11, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants