Skip to content

remove persisted store#4089

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:remove-store
Sep 21, 2020
Merged

remove persisted store#4089
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:remove-store

Conversation

@lionelvillard
Copy link
Copy Markdown
Contributor

@lionelvillard lionelvillard commented Sep 21, 2020

The mt adapter library does not use it anymore and the test is flaky.

Proposed Changes

  • Remove PersistedStore

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 21, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Sep 21, 2020

/cc @matzew

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Sep 21, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

.Test
test/conformance.TestSourceStatus/Long_living_sources_have_Ready_status_condition/ApiServerSource-sources.knative.dev/v1beta1
test/conformance.TestSourceStatus/Long_living_sources_have_Ready_status_condition
test/conformance.TestSourceStatus
test/conformance.TestBrokerV1Beta1DataPlaneConsumer/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1DataPlaneConsumer
test/conformance.TestBrokerV1Beta1DataPlaneIngress/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1DataPlaneIngress

and 89 more.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Sep 21, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 05e9506 into knative:master Sep 21, 2020
@aliok aliok mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok

@aslom aslom Awaiting requested review from aslom

@matzew matzew Awaiting requested review from matzew

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lionelvillard @knative-test-reporter-robot @vaikas @knative-prow-robot @googlebot