adding test grid and fixing go doc link#4109
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
devguyio
left a comment
devguyio
left a comment
There was a problem hiding this comment.
One comment on slack link
| [](https://github.com/knative/eventing/blob/master/LICENSE) | ||
| [](https://knative.slack.com) | ||
| [](https://testgrid.knative.dev/eventing) | ||
| [](https://knative.slack.com/archives/C9JP909F0) |
There was a problem hiding this comment.
I wonder if we should have this point to slack.knative.dev instead? I mean first target audience for this should be people who are NOT in slack already and dunno how to find us, I always feel that pointing to the non-invitation link is a barrier (because there're zero instructions on how the hell can I get invited on that "sign in" page). not sure what you think @n3wscott
There was a problem hiding this comment.
the goal of that link is to get someone from github to the #eventing channel
There was a problem hiding this comment.
@n3wscott understood, but there are two cases, either he's in already, i.e. he knows his way around. Or he never joined, and the sing-in page will be a gatekeeper for him to join. Does that make sense?
There was a problem hiding this comment.
I'm fine if you wanna take this off the scope of this PR, just wanted to float this idea around.
There was a problem hiding this comment.
this PR changes the original link from the default channel in slack to the eventing room. So maybe what you are asking for is a signup badge? let me work that up
|
/assign |
|
@devguyio what do you think now? |
|
@n3wscott awesome! |
4 participants
Proposed Changes
Release Note