Skip to content

enable source crd test#4154

Merged
knative-prow-robot merged 5 commits into
knative:masterfrom
runzexia:crd-controller-test
Oct 2, 2020
Merged

enable source crd test#4154
knative-prow-robot merged 5 commits into
knative:masterfrom
runzexia:crd-controller-test

Conversation

@runzexia
Copy link
Copy Markdown
Contributor

Signed-off-by: runzexia root@junwuhui.cn

ref #3868

Signed-off-by: runzexia <root@junwuhui.cn>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 28, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Welcome @runzexia! It looks like this is your first PR to knative/eventing 🎉

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @runzexia. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2020
Signed-off-by: runzexia <root@junwuhui.cn>
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2020
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
Signed-off-by: runzexia <root@junwuhui.cn>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

Signed-off-by: runzexia <root@junwuhui.cn>
@runzexia
Copy link
Copy Markdown
Contributor Author

runzexia commented Sep 29, 2020

gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '.pb.go' -prune -o -type f -name '.go' -print)
got some error with fmt cmd

gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
find: illegal option -- p
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
error: cannot use -w with standard input
 goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

@runzexia
Copy link
Copy Markdown
Contributor Author

gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '.pb.go' -prune -o -type f -name '.go' -print)
got some error with fmt cmd

gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
find: illegal option -- p
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
error: cannot use -w with standard input
 goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

find difference
https://stackoverflow.com/questions/17548854/difference-between-mac-find-and-linux-find

Signed-off-by: runzexia <root@junwuhui.cn>
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/source/crd/crd.go 17.0% 66.0% 49.1

@runzexia
Copy link
Copy Markdown
Contributor Author

as #2770 (comment)
this controller did not impl finalizer, the clean up code would not be run.

@lionelvillard
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, runzexia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@knative-prow-robot knative-prow-robot merged commit 46407e8 into knative:master Oct 2, 2020
@grantr
Copy link
Copy Markdown
Contributor

grantr commented Oct 2, 2020

Thanks for your first contribution @runzexia! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants