Skip to content

ApiServerSource set Status.Ce Attributes based on the mode#4192

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
capri-xiyue:issue_4180
Oct 6, 2020
Merged

ApiServerSource set Status.Ce Attributes based on the mode#4192
knative-prow-robot merged 3 commits into
knative:masterfrom
capri-xiyue:issue_4180

Conversation

@capri-xiyue
Copy link
Copy Markdown
Contributor

Fixes #4180

Proposed Changes

  • 🐛ApiServerSource set Status.Ce Attributes based on the mode

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 1, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 1, 2020
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/assign @nachocano

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestPingSourceV1Beta1

@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-integration-tests

Comment thread pkg/reconciler/apiserversource/apiserversource.go Outdated
Comment thread pkg/reconciler/apiserversource/apiserversource.go
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

assign @n3wscott

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserversource/apiserversource.go 77.2% 76.5% -0.7

@nachocano
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@knative-prow-robot knative-prow-robot merged commit 9037312 into knative:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApiServerSource should set Status.Ce Attributes based on the mode

7 participants