Skip to content

Adding GetCondition and patch merge to ClusterProvisionerStatus#436

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
n3wscott:use_pkg_conditionals_updates
Sep 18, 2018
Merged

Adding GetCondition and patch merge to ClusterProvisionerStatus#436
knative-prow-robot merged 2 commits into
knative:masterfrom
n3wscott:use_pkg_conditionals_updates

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

Relates to #434

Proposed Changes

  • Adding GetCondition on ClusterProvisionerStatus
  • Adding patchStrategy:"merge" to ClusterProvisionerStatus.Conditions

Release Note

None

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/assign @grantr

Addressed feedback from #434

@n3wscott n3wscott changed the title Addressing feedback, adding GetCondition method and merge strat. Adding GetCondition patch merge to ClusterProvisionerStatus Sep 18, 2018
@n3wscott n3wscott changed the title Adding GetCondition patch merge to ClusterProvisionerStatus Adding GetCondition and patch merge to ClusterProvisionerStatus Sep 18, 2018
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@knative-prow-robot knative-prow-robot merged commit 67761f0 into knative:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants