Add support for dynamic actions#44
Closed
inlined wants to merge 14 commits into
Closed
Conversation
* Changes to "triggers":
* Renamed the "triggers" pacakge to "sources" to avoid confusion.
* EventTriggers (FKA Sources) now take EventTriggers instead of
just params.
* source.EventTrigger is different from v1alpha1.EventTrigger because
the latter has embedded Raw types that would be hard to use.
* Updated GitHub sample:
* Renamed the EventSource to "github.com" rather than just "github"
to better align with GCF. I think this revealed something about
the control plane model that I want to discuss.
* Updated pullrequest.yaml to match new format.
* As part of this I made a minor change to update-deps to work on mac
(gnu-sed still required).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inlined The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
approved
Contributor
Author
|
/assign @vaikas-google Once #40 is accepted, I'll rebase this and it gets much simpler. Otherwise you can review as of "Change Bind.Spec.Action and regenerate" |
Contributor
Author
|
/unassign @vaikas-google |
Also refactored some of the Bind controller so that we can cleanly handle Binds without an event trigger. Binds without triggers aren't a great golden road, but will help us experiment with new event providers (e.g. those demoed at KubeCon) with zero infra changes.
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
Apr 8, 2019
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Dec 23, 2022
The PingSource was not exporting metrics on the advertised port on the Deployment (metrics, 9090) but it was using 9092. In addition any component using the adapter/v2 code suffers from unexported metrics because the exporter was created only after an update to `config-observability` since the watcher was started before the observer was registered as side effect of calling `CreateLogger`. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #42
THIS PR BUILDS UPON #40, so it includes all of that code. The actual diff is +208 -148 LOC
Builds upon
Proposed Changes
elafros.dev/Routeandeventing.elafros.dev/EventLoggerPOSTing to /v1alpha1/namespaces//flows/:sendEvent will deliver events to the correct destinationcurlyour events)