Enable more sources on e2e test cfg#4434
Merged
Merged
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
area/test-and-release
Member
Author
|
/assign @devguyio |
Codecov Report
@@ Coverage Diff @@
## master #4434 +/- ##
==========================================
+ Coverage 81.19% 81.27% +0.07%
==========================================
Files 281 282 +1
Lines 7981 8004 +23
==========================================
+ Hits 6480 6505 +25
Misses 1112 1112
+ Partials 389 387 -2
Continue to review full report at Codecov.
|
Member
Author
|
/refresh |
matzew
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
enable_more_sources
branch
from
ce7629d to
5eaeb79
Compare
devguyio
reviewed
Nov 4, 2020
Contributor
devguyio
left a comment
devguyio
left a comment
There was a problem hiding this comment.
Just some suggestion to clarify the message which was confusing IMHO and removed a duplicate -channels option in e2e tests script
Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>
Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>
Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
Release Note
Docs