Skip to content

Adding readynessProbe#4478

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:issues/4473
Nov 6, 2020
Merged

Adding readynessProbe#4478
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:issues/4473

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Nov 6, 2020 •
edited
Loading

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #4473

Proposed Changes

  • adding readynessProble

Release Note

Docs

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #4478 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4478   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         282      282           
  Lines        8004     8004           
=======================================
  Hits         6505     6505           
  Misses       1112     1112           
  Partials      387      387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f36e92e...c515d9f. Read the comment docs.

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Nov 6, 2020

@cardil the upgrade tests here seem affected

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Nov 6, 2020

/test pull-knative-eventing-upgrade-tests

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Nov 6, 2020

@cardil the upgrade tests here seem affected

actutally, not :trollface:

@maschmid
Copy link
Copy Markdown
Contributor

maschmid commented Nov 6, 2020

We should perhaps add Readiness probe to broker-filter as well while at it?

@matzew
Adding readynessProbe
c515d9f 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020
@cardil
Copy link
Copy Markdown
Contributor

cardil commented Nov 6, 2020

+10 this might help greatly.

@zhongduo
Copy link
Copy Markdown
Contributor

zhongduo commented Nov 6, 2020

/assign

@zhongduo
Copy link
Copy Markdown
Contributor

zhongduo commented Nov 6, 2020

/lgtm
/hold in case you want to wait for a second opinion.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 6, 2020
@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Nov 6, 2020

/lgtm

@slinkydeveloper
Copy link
Copy Markdown
Contributor

slinkydeveloper commented Nov 6, 2020

/lgtm

@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Nov 6, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2020
@knative-prow-robot knative-prow-robot merged commit 33d3d9f into knative:master Nov 6, 2020
@devguyio devguyio mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@devguyio devguyio

@slinkydeveloper slinkydeveloper

@zhongduo zhongduo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broker-ingress pods Ready before accepting connections, "Fanout had an error": "failed to forward reply", "connection refused"

7 participants

@matzew @knative-prow-robot @maschmid @cardil @zhongduo @devguyio @slinkydeveloper