Skip to content

Fix nits in PingSource v1beta2#4537

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
eclipselu:dev
Nov 17, 2020
Merged

Fix nits in PingSource v1beta2#4537
knative-prow-robot merged 1 commit into
knative:masterfrom
eclipselu:dev

Conversation

@eclipselu
Copy link
Copy Markdown
Contributor

Follow-up to #4474

Proposed Changes

Release Note


Docs

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 17, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2020
@eclipselu
Copy link
Copy Markdown
Contributor Author

/assign @nachocano

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2020

Codecov Report

Merging #4537 (039cafd) into master (3fca4a2) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4537      +/-   ##
==========================================
- Coverage   81.42%   81.31%   -0.11%     
==========================================
  Files         290      290              
  Lines        8150     8157       +7     
==========================================
- Hits         6636     6633       -3     
- Misses       1121     1126       +5     
- Partials      393      398       +5     
Impacted Files Coverage Δ
pkg/apis/sources/v1beta2/ping_types.go 100.00% <ø> (ø)
pkg/adapter/mtping/runner.go 84.48% <25.00%> (-9.97%) ⬇️
pkg/apis/sources/v1beta1/ping_conversion.go 89.09% <33.33%> (-6.99%) ⬇️
pkg/apis/sources/v1beta2/ping_validation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fca4a2...039cafd. Read the comment docs.

Comment thread pkg/adapter/mtping/runner.go Outdated
@nachocano
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eclipselu, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/runner.go 97.8% 91.8% -5.9
pkg/apis/sources/v1beta1/ping_conversion.go 97.7% 93.8% -4.0

@knative-prow-robot knative-prow-robot merged commit be93f94 into knative:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants