Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/core/resources/pingsource.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ spec:
- <<: *version
name: v1beta1
served: true
storage: true
storage: false
schema:
openAPIV3Schema:
type: object
Expand Down Expand Up @@ -323,7 +323,7 @@ spec:
- <<: *version
name: v1beta2
served: true
storage: false
storage: true
schema:
openAPIV3Schema:
type: object
Expand Down
46 changes: 46 additions & 0 deletions config/post-install/v0.21.0/clusterrole.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: v0-21-0-knative-eventing-post-install-job-role
labels:
eventing.knative.dev/release: devel
rules:
# Storage version upgrader needs to be able to patch CRDs.
- apiGroups:
- "apiextensions.k8s.io"
resources:
- "customresourcedefinitions"
- "customresourcedefinitions/status"
verbs:
- "get"
- "list"
- "update"
- "patch"
- "watch"
# Our own resources we care about.
- apiGroups:
- "sources.knative.dev"
resources:
- "pingsources"
verbs:
- "get"
- "list"
- "create"
- "update"
- "delete"
- "patch"
- "watch"
19 changes: 19 additions & 0 deletions config/post-install/v0.21.0/placeholder.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
Copyright 2020 The Knative Authors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

// Package postinstall is a placeholder that allows us to pull in config files
// via go mod vendor.
package postinstall
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lionelvillard @pierDipi the PingSource migration is using v0.21.1, we should try to merge this with PRs like #4658 to make sure we have single post install directory. Do you think we should bring up in the eventing meeting?

Copy link
Copy Markdown
Contributor Author

@eclipselu eclipselu Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove the post-install directory after 0.20.0 is cut and add this commit back in?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove the post-install directory after 0.20.0 is cut add this commit back in?

yes, like serving and as expected by the operator (@houshengbo, @Cynocracy)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd expect a simple PR like #4658.
I guess we can discuss this asynchronously on an issue or PR.
Perhaps a document describing the post-install job story might be helpful.

38 changes: 38 additions & 0 deletions config/post-install/v0.21.0/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: v1
kind: ServiceAccount
metadata:
name: v0-21-0-knative-eventing-post-install-job
namespace: knative-eventing
labels:
eventing.knative.dev/release: devel

---

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: v0-21-0-knative-eventing-post-install-job-role-binding
labels:
eventing.knative.dev/release: devel
subjects:
- kind: ServiceAccount
name: v0-21-0-knative-eventing-post-install-job
namespace: knative-eventing
roleRef:
kind: ClusterRole
name: v0-21-0-knative-eventing-post-install-job-role
apiGroup: rbac.authorization.k8s.io
41 changes: 41 additions & 0 deletions config/post-install/v0.21.0/storage-version-migration.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: batch/v1
kind: Job
metadata:
name: v0-21-0-storage-version-migration
namespace: knative-eventing
labels:
app: v0-21-0-storage-version-migration
eventing.knative.dev/release: devel
spec:
ttlSecondsAfterFinished: 600
backoffLimit: 10
template:
metadata:
labels:
app: v0-21-0-storage-version-migration
annotations:
sidecar.istio.io/inject: "false"
spec:
serviceAccountName: v0-21-0-knative-eventing-post-install-job
restartPolicy: OnFailure
containers:
- name: migrate
# This is the Go import path for the binary that is containerized
# and substituted here.
image: ko://knative.dev/eventing/vendor/knative.dev/pkg/apiextensions/storageversion/cmd/migrate
args:
- "pingsources.sources.knative.dev"