Subscription controller tweaks#459
Merged
knative-prow-robot merged 6 commits intoSep 25, 2018
Merged
Conversation
These make the controller slightly easier to read. Assuming that the Ready condition flip to true is intended to be a FromReady flip.
Replaced with Generation duck type.
knative-prow-robot
added
the
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
n3wscott
reviewed
Sep 24, 2018
| Type: v1alpha1.SubscriptionConditionReferencesResolved, | ||
| Status: corev1.ConditionTrue, | ||
| }) | ||
| subscription.Status.MarkReferencesResolved() |
Contributor
|
/LGTM this cleaned up a lot of busy work in the controller. Thanks!! |
Time fields in conditions often need to be ignored because they rarely compare as equal. Setting IgnoreTimes true in the test case will cause diffs to ignore apis.VolatileTime values.
All conditions are now defaulted to Unknown on first reconcile.
|
The following is the coverage report on pkg/.
|
Contributor
|
/lgtm |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Mar 3, 2020
remove unneeded patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup tweaks to #437 as suggested by @n3wscott:
IsReadyandMark*functions to manage conditions easilyGetSpecJSONand useduck.Generationinstead