Skip to content

[0.19] Backport https://github.com/knative/pkg/pull/1963 #4661

Merged
knative-prow-robot merged 1 commit into
knative:release-0.19from
skonto:prom-v.19.0-up
Dec 16, 2020
Merged

[0.19] Backport https://github.com/knative/pkg/pull/1963 #4661
knative-prow-robot merged 1 commit into
knative:release-0.19from
skonto:prom-v.19.0-up

Conversation

@skonto
Copy link
Copy Markdown
Contributor

@skonto skonto commented Dec 16, 2020

Used go get -u knative.dev/pkg@release-0.19 to bring the backport in.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 16, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @skonto. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 16, 2020
@skonto
Copy link
Copy Markdown
Contributor Author

skonto commented Dec 16, 2020

/cc @matzew

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-0.19@0e55a6a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.19    #4661   +/-   ##
===============================================
  Coverage                ?   81.27%           
===============================================
  Files                   ?      282           
  Lines                   ?     8004           
  Branches                ?        0           
===============================================
  Hits                    ?     6505           
  Misses                  ?     1112           
  Partials                ?      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e55a6a...e349418. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit c98493d into knative:release-0.19 Dec 16, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Jan 4, 2021
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Jan 4, 2021
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants