Skip to content

Fixup ping source dataMaxSize configmap#4894

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
lberk:fixPingDataMaxSize
Feb 17, 2021
Merged

Fixup ping source dataMaxSize configmap#4894
knative-prow-robot merged 4 commits into
knative:masterfrom
lberk:fixPingDataMaxSize

Conversation

@lberk
Copy link
Copy Markdown
Member

@lberk lberk commented Feb 17, 2021

  • Configmap should be basic key/value pair, not a string for a yaml struct
  • Provide example dataMaxSize configmap config
  • Correct example-checksum annotation
  • No mashalling from yaml needed, strconv directly to int64
  • Add unit testing for ConfigMap reading
  • Remove erroneous broker parsing comments/function from copied implementation
  • Rename configmap to match naming conventions
  • update bsize len assignment to match int64 size

Proposed Changes

  • 🧹 Cleanup ping dataMaxSize configmap implemenation

@lberk
Fixup ping source dataMaxSize configmap
8b9e8d8 
- Configmap should be basic key/value pair, not a string for a yaml struct
- Provide example dataMaxSize configmap config
- Correct example-checksum annotation
- No mashalling from yaml needed, strconv directly to int64
- Add unit testing for ConfigMap reading
- Remove erroneous broker parsing comments/function from copied implementation
- Rename configmap to match naming conventions
- update bsize len assignment to match int64 size
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 17, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2021
@lberk
Copy link
Copy Markdown
Member Author

lberk commented Feb 17, 2021

cc/ @antoineco @matzew @lionelvillard @cr22rc

@lberk lberk mentioned this pull request Feb 17, 2021
Closed
@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Feb 17, 2021

FYI @tayarani.

@lberk lberk mentioned this pull request Feb 17, 2021
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #4894 (873ed6e) into master (30d9fa3) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4894      +/-   ##
==========================================
- Coverage   81.41%   81.14%   -0.28%     
==========================================
  Files         292      294       +2     
  Lines        8328     8383      +55     
==========================================
+ Hits         6780     6802      +22     
- Misses       1142     1175      +33     
  Partials      406      406
Impacted Files Coverage Δ
pkg/apis/sources/config/ping_defaults.go 55.55% <100.00%> (ø)
pkg/apis/sources/v1alpha2/ping_validation.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1beta1/ping_validation.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1beta2/ping_validation.go 100.00% <100.00%> (ø)
pkg/kncloudevents/message_sender.go 82.25% <100.00%> (+4.25%) ⬆️
pkg/apis/sources/config/store.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d9fa3...07455db. Read the comment docs.

antoineco
antoineco reviewed Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@antoineco antoineco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for tackling this.

Comment thread config/core/configmaps/default-pingsource.yaml Outdated
Comment thread pkg/apis/sources/config/ping_defaults.go Outdated
@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Feb 17, 2021

/lgtm

/hold for nit

@lberk Thanks for lot for saving the day!

@tayarani Please let us know if this PR fixes the issue you are seeing.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@lberk
Copy link
Copy Markdown
Member Author

lberk commented Feb 17, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
antoineco
antoineco approved these changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Feb 17, 2021

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/config/ping_defaults.go Do not exist 55.6%
pkg/apis/sources/config/store.go Do not exist 0.0%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 17, 2021

@lberk: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 07455db link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit fb8e3b4 into knative:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

2 more reviewers

@lionelvillard lionelvillard lionelvillard left review comments

@antoineco antoineco antoineco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antoineco antoineco

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lberk @lionelvillard @knative-prow-robot @knative-metrics-robot @antoineco