Delivery timeout by slinkydeveloper · Pull Request #5149 · knative/eventing

slinkydeveloper · 2021-03-25T10:55:07Z

Proposed Changes

🎁 Added DeliverySpec.Timeout

Release Note

Added `DeliverySpec.Timeout`

Docs

I'm going to create the docs as soon as we implement this in our components

Spec PR: knative/specs#15

codecov · 2021-03-25T11:22:12Z

Codecov Report

Merging #5149 (fb56da6) into main (6adafe5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5149      +/-   ##
==========================================
+ Coverage   82.62%   82.65%   +0.03%     
==========================================
  Files         198      198              
  Lines        6117     6130      +13     
==========================================
+ Hits         5054     5067      +13     
  Misses        737      737              
  Partials      326      326

Impacted Files	Coverage Δ
pkg/apis/duck/v1/delivery_types.go	`91.66% <100.00%> (+3.43%)`	⬆️
pkg/apis/duck/v1beta1/delivery_conversion.go	`100.00% <100.00%> (ø)`
pkg/apis/duck/v1beta1/delivery_types.go	`90.47% <100.00%> (+2.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adafe5...fb56da6. Read the comment docs.

slinkydeveloper · 2021-03-25T11:23:54Z

/retest

slinkydeveloper · 2021-06-08T12:53:05Z

/hold

This requires the lazy consensus approval per https://github.com/knative/eventing/blob/main/docs/experimental-features.md#feature-proposal-development-and-graduation-process

matzew · 2021-06-14T13:40:04Z

LGTM

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Fixed validation Fixed CRD Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-metrics-robot · 2021-06-18T07:31:34Z

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/duck/v1/delivery_types.go	93.3%	95.2%	1.9
pkg/apis/duck/v1beta1/delivery_types.go	93.3%	94.7%	1.4

slinkydeveloper · 2021-06-22T08:07:19Z

/unhold

https://groups.google.com/g/knative-dev/c/7h1p0eBmUuo/m/lTzaSULKAQAJ

matzew

/lgtm
/approve

knative-prow-robot · 2021-06-22T08:41:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2021

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2021

n3wscott reviewed Mar 25, 2021

View reviewed changes

Comment thread pkg/apis/duck/v1/delivery_types.go

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021

This was referenced Mar 25, 2021

Add timeout to the delivery spec knative/specs#15

Closed

[Experimental] DeliverySpec Timeout #5148

Open

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2021

slinkydeveloper force-pushed the delivery_timeout branch from 2348d8d to 2859c59 Compare June 8, 2021 12:51

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021

slinkydeveloper mentioned this pull request Jun 14, 2021

Glue Delivery.Timeout to RetryConfig.RequestTimeout #5507

Merged

5 tasks

matzew reviewed Jun 14, 2021

View reviewed changes

Comment thread config/core/configmaps/features.yaml

pierDipi reviewed Jun 14, 2021

View reviewed changes

Comment thread pkg/apis/duck/v1/delivery_types.go Outdated

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2021

slinkydeveloper added 7 commits June 18, 2021 08:46

Added DeliverySpec.Timeout

22951b5

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

codegen

803713e

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Yamls

5825f06

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Added the feature flag

7df4e62

Fixed validation Fixed CRD Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Fix validation UT

291b51c

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Added comment

2461bc7

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Specify the value has to be greater than 0

94a9dfa

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper force-pushed the delivery_timeout branch from 24289e2 to 94a9dfa Compare June 18, 2021 06:47

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2021

Update docs

fb56da6

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021

matzew approved these changes Jun 22, 2021

View reviewed changes

knative-prow-robot assigned matzew Jun 22, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021

knative-prow-robot merged commit 9cd2858 into knative:main Jun 22, 2021

slinkydeveloper deleted the delivery_timeout branch June 22, 2021 09:30

devguyio mentioned this pull request Sep 9, 2021

Implement CE Subscriptions filters #5715

Merged

5 tasks

lionelvillard mentioned this pull request Sep 27, 2021

Add timeout experimental feature to the spec knative/specs#76

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delivery timeout#5149

Delivery timeout#5149
knative-prow-robot merged 8 commits into
knative:mainfrom
slinkydeveloper:delivery_timeout

slinkydeveloper commented Mar 25, 2021 •

edited

Loading

Uh oh!

codecov Bot commented Mar 25, 2021 •

edited

Loading

Uh oh!

slinkydeveloper commented Mar 25, 2021

Uh oh!

Uh oh!

slinkydeveloper commented Jun 8, 2021

Uh oh!

Uh oh!

matzew commented Jun 14, 2021

Uh oh!

Uh oh!

knative-metrics-robot commented Jun 18, 2021

Uh oh!

slinkydeveloper commented Jun 22, 2021 •

edited

Loading

Uh oh!

matzew left a comment

Uh oh!

knative-prow-robot commented Jun 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

slinkydeveloper commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

codecov Bot commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

slinkydeveloper commented Mar 25, 2021

Uh oh!

Uh oh!

slinkydeveloper commented Jun 8, 2021

Uh oh!

Uh oh!

matzew commented Jun 14, 2021

Uh oh!

Uh oh!

knative-metrics-robot commented Jun 18, 2021

Uh oh!

slinkydeveloper commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matzew left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Jun 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

slinkydeveloper commented Mar 25, 2021 •

edited

Loading

codecov Bot commented Mar 25, 2021 •

edited

Loading

slinkydeveloper commented Jun 22, 2021 •

edited

Loading