Skip to content

Adding ProvisionedObjectStatus to Source.#517

Closed
n3wscott wants to merge 5 commits into
knative:masterfrom
n3wscott:ProvisionedObjectStatus
Closed

Adding ProvisionedObjectStatus to Source.#517
n3wscott wants to merge 5 commits into
knative:masterfrom
n3wscott:ProvisionedObjectStatus

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott commented Oct 10, 2018

TODO:
[ x] - Add tests for new object.
[ ] - Update the spec to match what is needed inside of k8s

Proposed Changes

  • The spec outlines ProvisionedObjectStatus but the Source object did not have that on Status. Adding.

Release Note

Added source.status.provisioned[].

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n3wscott
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: grantr

If they are not already assigned, you can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2018
Comment thread pkg/apis/eventing/v1alpha1/source_types.go Outdated
@n3wscott n3wscott changed the title Adding ProvisionedObjectStatus to Source. [WIP] Adding ProvisionedObjectStatus to Source. Oct 11, 2018
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2018
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/source_types.go 100.0% 38.5% -61.5

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-go-coverage

@n3wscott n3wscott changed the title [WIP] Adding ProvisionedObjectStatus to Source. Adding ProvisionedObjectStatus to Source. Oct 16, 2018
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/assign @grantr
/cc @scothis

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Oct 22, 2018

@n3wscott sorry for the delay in approving this. 😞 Is it still relevant now that we're removing the Source CRD?

@n3wscott n3wscott closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants