[WIP] Trigger.Filter now supports the CNCF Subscription API

[slinkydeveloper]

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Part of #5204

Proposed Changes

• 🎁 Add fields and update godocs to conform to the CNCF Subscription API. This is not breaking.

Release Note

Now Trigger.filter supports the CNCF Subscription API filters

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from slinkydeveloper after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #5205 (89db05f) into main (5171353) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5205      +/-   ##
==========================================
+ Coverage   83.31%   83.47%   +0.15%     
==========================================
  Files         243      243              
  Lines        6917     6934      +17     
==========================================
+ Hits         5763     5788      +25     
+ Misses        801      797       -4     
+ Partials      353      349       -4     

Impacted Files	Coverage Δ
pkg/apis/eventing/v1/trigger_types.go	100.00% <ø> (ø)
pkg/apis/eventing/v1/trigger_validation.go	94.53% <100.00%> (+4.12%)	⬆️
pkg/broker/ingress/ingress_handler.go	62.76% <0.00%> (ø)
pkg/apis/sources/v1beta1/ping_conversion.go	94.44% <0.00%> (+7.95%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5171353...89db05f. Read the comment docs.

[n3wscott]

I don't think this can land until we get to our 1.0 milestone. it changes too much for what the eventing spec is for triggers.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/eventing/v1/trigger_validation.go	96.6%	97.9%	1.3

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.