Skip to content

fix(PingSource): remove annotation based conversion logic#5233

Merged
knative-prow-robot merged 1 commit into
knative:release-0.21from
eclipselu:fix-0.21
Apr 13, 2021
Merged

fix(PingSource): remove annotation based conversion logic#5233
knative-prow-robot merged 1 commit into
knative:release-0.21from
eclipselu:fix-0.21

Conversation

@eclipselu
Copy link
Copy Markdown
Contributor

@eclipselu eclipselu commented Apr 12, 2021 •
edited
Loading

Cherry-picked from #5153
Related issue: #5137

Proposed Changes

  • v1beta1 will not guaranteed to be roundtrip-able (in the case that jsonData cannot be marshalled into json, e.g. jsonData="hello"), but the cloudevent on the wire stays the same.
  • duckv1.SourceSpec, TimeZone, Schedule will be populated when called by v1beta1 clients
  • object with v1beta2-specific features (dataBase64, contentType beyond application/json) will not populate jsonData field when converted to v1beta1.

Release Note

:bug: duckv1.SourceSpec, TimeZone, Schedule will be populated when called by v1beta1/v1alpha2 clients

Docs

@eclipselu
fix(PingSource): remove annotation based conversion logic
8fa18ff 
- v1beta1 will not guaranteed to be roundtrip-able (in the case that jsonData cannot be marshalled into json, e.g. jsonData="hello"), but the cloudevent on the wire stays the same.
- duckv1.SourceSpec, TimeZone, Schedule will be populated when called by v1beta1 clients
- object with v1beta2-specific features (dataBase64, contentType beyond `application/json`) will not populate jsonData field when converted to v1beta1.
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 12, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 12, 2021
@eclipselu
Copy link
Copy Markdown
Contributor Author

eclipselu commented Apr 12, 2021

@lionelvillard pls take a look, thanks

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-0.21@418df62). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.21    #5233   +/-   ##
===============================================
  Coverage                ?   81.56%           
===============================================
  Files                   ?      294           
  Lines                   ?     8365           
  Branches                ?        0           
===============================================
  Hits                    ?     6823           
  Misses                  ?     1138           
  Partials                ?      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418df62...8fa18ff. Read the comment docs.

@eclipselu
Copy link
Copy Markdown
Contributor Author

eclipselu commented Apr 13, 2021

@lionelvillard this PR needs to be back-ported as well, thanks!

@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Apr 13, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@knative-prow-robot knative-prow-robot merged commit 9c33fbf into knative:release-0.21 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eclipselu @lionelvillard @knative-prow-robot