fix(PingSource): remove annotation based conversion logic#5234
Merged
Conversation
- v1beta1 will not guaranteed to be roundtrip-able (in the case that jsonData cannot be marshalled into json, e.g. jsonData="hello"), but the cloudevent on the wire stays the same. - duckv1.SourceSpec, TimeZone, Schedule will be populated when called by v1beta1 clients - object with v1beta2-specific features (dataBase64, contentType beyond `application/json`) will not populate jsonData field when converted to v1beta1.
knative-prow-robot
added
the
size/L
Contributor
Author
|
@lionelvillard pls take a look, thanks |
Codecov Report
@@ Coverage Diff @@
## release-0.22 #5234 +/- ##
================================================
+ Coverage 83.98% 84.00% +0.02%
================================================
Files 283 283
Lines 7966 7928 -38
================================================
- Hits 6690 6660 -30
+ Misses 901 897 -4
+ Partials 375 371 -4
Continue to review full report at Codecov.
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #5153
Related issue: #5137
Proposed Changes
application/json) will not populate jsonData field when converted to v1beta1.Release Note
Docs