[QE] Allow to change SUT for upgrade tests by cardil · Pull Request #5321 · knative/eventing

cardil · 2021-04-28T09:51:54Z

Proposed Changes

Allow to change a System under Tests (SUT) in upgrade tests from downstream repos

knative-prow-robot · 2021-04-28T09:51:59Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2021-04-29T13:51:37Z

Codecov Report

Merging #5321 (60f9c30) into main (5af518d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5321   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         194      194           
  Lines        5987     5987           
=======================================
  Hits         4947     4947           
  Misses        717      717           
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af518d...60f9c30. Read the comment docs.

…ntinual-test-change-sut

cardil · 2021-05-05T23:48:59Z

/test all

cardil · 2021-05-06T10:53:51Z

/test all

…ntinual-test-change-sut

…ntinual-test-change-sut Conflicts fixed: * test/upgrade/prober/configuration.go

matzew

/lgtm
/approve

knative-prow-robot · 2021-05-21T02:40:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review

Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test

Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review

* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test

Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review

* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>

* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test

* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>

* [0.22] Backport of PRs 5321 and 4815 (from #1284) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of knative#5444 (#1286) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir

* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>

* [v0.22.0] Backport of PR 563 (use of #215) * Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com> * Restore manually changed vendor files * Skipping subscription readiness when scaling dispatcher test (knative-sandbox#573) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Lukas Berk <lberk@redhat.com> Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>

[0.23] Backport of PRs 4815 5321 5444 (from knative#1309) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of (knative#5444) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir

Backport of (knative#563) * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review

* [0.23] Backport of PRs 4815 5321 5444 [0.23] Backport of PRs 4815 5321 5444 (from #1309) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of (knative#5444) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir * Revert "Update deps"

* [QE] Continual tests for KafkaSource for upgrade testing Backport of (knative#563) * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Add wathola-kafka-sender test image * update pkg * Revert "update deps" * Remove the interim personal fork

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2021

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 28, 2021

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 28, 2021

cardil mentioned this pull request Apr 28, 2021

[QE] Continual tests for KafkaSource for upgrade testing knative-extensions/eventing-kafka#563

Merged

cardil force-pushed the feature/upgrades-continual-test-change-sut branch from 88a6d89 to fbfc068 Compare April 29, 2021 12:25

Introduction of SUT package

7031375

cardil force-pushed the feature/upgrades-continual-test-change-sut branch from fbfc068 to 7031375 Compare April 29, 2021 13:44

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2021

cardil added 2 commits May 5, 2021 13:53

Refactor to keep used interfaces and deprecate them first

1725578

Update-codegen

a6660f7

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2021

Merge remote-tracking branch 'upstream/main' into feature/upgrades-co…

ef8e4c0

…ntinual-test-change-sut

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2021

cardil added 2 commits May 5, 2021 20:15

Restoring configuration options, to have Deprecated status instead

4291ff3

Working e2e test

ea1404b

cardil force-pushed the feature/upgrades-continual-test-change-sut branch from 755538b to ea1404b Compare May 5, 2021 23:48

Fixing NPE in upgrade tests

94b2064

cardil added 3 commits May 6, 2021 13:52

Introducing new interfaces for configuration and easy execution

51be9e0

Merge remote-tracking branch 'upstream/main' into feature/upgrades-co…

5bced8b

…ntinual-test-change-sut

NPE fix in continual.go@55

2f3cb57

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2021

Removal of ensure.NoError

01fb8da

cardil force-pushed the feature/upgrades-continual-test-change-sut branch from 40d515f to 01fb8da Compare May 6, 2021 12:32

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021

Merge remote-tracking branch 'upstream/main' into feature/upgrades-co…

60f9c30

…ntinual-test-change-sut Conflicts fixed: * test/upgrade/prober/configuration.go

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2021

matzew approved these changes May 21, 2021

View reviewed changes

knative-prow-robot assigned matzew May 21, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021

knative-prow-robot merged commit cca60b3 into knative:main May 21, 2021

cardil deleted the feature/upgrades-continual-test-change-sut branch May 21, 2021 07:27

cardil mentioned this pull request May 25, 2021

[v0.21.0] Backport of PRs 5321 and 4815 openshift/knative-eventing#1284

Merged

cardil mentioned this pull request Jun 9, 2021

[0.22] Backport of PRs 4815 5321 5444 openshift/knative-eventing#1309

Merged

cardil mentioned this pull request Jun 21, 2021

[0.23] Backport of PRs 4815 5321 5444 openshift/knative-eventing#1320

Merged

cardil mentioned this pull request Jun 28, 2021

[QE] Remove all deprecated code in test/upgrade package #5554

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QE] Allow to change SUT for upgrade tests#5321

[QE] Allow to change SUT for upgrade tests#5321
knative-prow-robot merged 29 commits into
knative:mainfrom
cardil:feature/upgrades-continual-test-change-sut

cardil commented Apr 28, 2021

Uh oh!

knative-prow-robot commented Apr 28, 2021

Uh oh!

codecov Bot commented Apr 29, 2021 •

edited

Loading

Uh oh!

cardil commented May 5, 2021

Uh oh!

cardil commented May 6, 2021

Uh oh!

matzew left a comment

Uh oh!

knative-prow-robot commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cardil commented Apr 28, 2021

Proposed Changes

Uh oh!

knative-prow-robot commented Apr 28, 2021

Uh oh!

codecov Bot commented Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cardil commented May 5, 2021

Uh oh!

cardil commented May 6, 2021

Uh oh!

matzew left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 29, 2021 •

edited

Loading