Refactor the repo to support development with "ko".#54
Merged
Conversation
google-prow-robot
added
the
size/L
vaikas
reviewed
Apr 27, 2018
Contributor
vaikas
left a comment
vaikas
left a comment
There was a problem hiding this comment.
Do the samples need any changes?
Contributor
|
/lgtm |
vaikas
approved these changes
Apr 28, 2018
Member
Author
|
I updated the sample as well. |
Contributor
|
/lgtm |
You can read more about `ko` [here](https://github.com/google/go-containerregistry/tree/master/cmd/ko#ko), but the tl;dr is that it is an experimental tool to replicate the current DevX with Bazel without the baggage Bazel comes with (learning curve, BUILD files, Java dependency, ...). I believe the supporting changes are generally useful these include: 1. Moving config files out of the root directory. This is to support the Kubernetes-style of applying an entire directory of configuration, potentially recursively (see below for an example). 1. Naming the image references we substitute around Go import paths. I find that this is a useful convention for expressing image provenance. These changes will support side-by-side development with Bazel and `ko`, until we make a judgement call on whether to remove Bazel. Here's an example of me running this locally: ```shell $ time ko apply -f config/ 2018/04/26 21:35:26 Go building github.com/elafros/eventing/cmd/controller 2018/04/26 21:35:36 Publishing us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller:latest 2018/04/26 21:35:37 mounted sha256:4fe6b1eadc150125dbdff941f6e199cef0ac6b5c37795bf7cdb263f02a05f955 2018/04/26 21:35:37 mounted sha256:eb05f3dbdb543cc610527248690575bacbbcebabe6ecf665b189cf18b541e3ca 2018/04/26 21:35:37 mounted sha256:a027959537706a82d5fcf8d13f5624b002e39b652c21ec01e787233921434f9a 2018/04/26 21:35:37 pushed us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller:latest 2018/04/26 21:35:37 Published us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller@sha256:3afe5f28f3c500f7bf6d2be142cad9b75afcc2a601a3e5709277a91284fd9e15 namespace "bind-system" created customresourcedefinition "binds.eventing.elafros.dev" created clusterrolebinding "bind-controller-admin" created deployment "bind-controller" created customresourcedefinition "eventsources.eventing.elafros.dev" created customresourcedefinition "eventtypes.eventing.elafros.dev" created serviceaccount "bind-controller" created real 0m13.700s user 0m10.976s sys 0m0.864s ```
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
dprotaso
added a commit
to dprotaso/eventing
that referenced
this pull request
Sep 12, 2018
Includes the following changes 1e7c2e7 Update static_watcher.go d688349 Include note about embedding the ManualWatcher in the InformedWatcher 767d6a5 Few changes to the configmap package 0122abd The test logger will now log the correct caller (knative#63) e7a4b0d Dont call flag.parse in pkg/test (knative#62) b213523 Update test-infra dependency (knative#61) 382a2bf Make kube_checks generic so that it can be used in serving (knative#58) 760afb6 cleanup (knative#57) eedc0a9 Make verify-codegen.sh compatible with OS X (knative#54) 6eff182 Remove docker repo from e2e flags (knative#53) 4be5c07 Vendor the test-infra scripts (knative#52) 8c687df Update WaitForEndpointState to return response (knative#51) 8f6a3be Update knative/pkg/test (knative#50) 3ca4270 Add a logkey for the reconcile key. (knative#49) 62d2560 Add Istio DestinationRule and Policy into Istio apis and clients (knative#43) f4a77d7 Add a common test clients file (knative#46) 450739d Add common test logging module (knative#45)
dprotaso
added a commit
to dprotaso/eventing
that referenced
this pull request
Sep 12, 2018
Includes the following changes: 8fc80de Few changes to the configmap package (knative#59) 0122abd The test logger will now log the correct caller (knative#63) e7a4b0d Dont call flag.parse in pkg/test (knative#62) b213523 Update test-infra dependency (knative#61) 382a2bf Make kube_checks generic so that it can be used in serving (knative#58) 760afb6 cleanup (knative#57) eedc0a9 Make verify-codegen.sh compatible with OS X (knative#54) 6eff182 Remove docker repo from e2e flags (knative#53) 4be5c07 Vendor the test-infra scripts (knative#52) 8c687df Update WaitForEndpointState to return response (knative#51) 8f6a3be Update knative/pkg/test (knative#50) 3ca4270 Add a logkey for the reconcile key. (knative#49) 62d2560 Add Istio DestinationRule and Policy into Istio apis and clients (knative#43) f4a77d7 Add a common test clients file (knative#46) 450739d Add common test logging module (knative#45
knative-prow-robot
pushed a commit
that referenced
this pull request
Sep 17, 2018
* bump knative/pkg to 8fc80de Includes the following changes: 8fc80de Few changes to the configmap package (#59) 0122abd The test logger will now log the correct caller (#63) e7a4b0d Dont call flag.parse in pkg/test (#62) b213523 Update test-infra dependency (#61) 382a2bf Make kube_checks generic so that it can be used in serving (#58) 760afb6 cleanup (#57) eedc0a9 Make verify-codegen.sh compatible with OS X (#54) 6eff182 Remove docker repo from e2e flags (#53) 4be5c07 Vendor the test-infra scripts (#52) 8c687df Update WaitForEndpointState to return response (#51) 8f6a3be Update knative/pkg/test (#50) 3ca4270 Add a logkey for the reconcile key. (#49) 62d2560 Add Istio DestinationRule and Policy into Istio apis and clients (#43) f4a77d7 Add a common test clients file (#46) 450739d Add common test logging module (#45 * Use updated methods that indicate that the configmap.Watcher is using an informer
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Apr 11, 2019
* Refactor the repo to support development with "ko". You can read more about `ko` [here](https://github.com/google/go-containerregistry/tree/master/cmd/ko#ko), but the tl;dr is that it is an experimental tool to replicate the current DevX with Bazel without the baggage Bazel comes with (learning curve, BUILD files, Java dependency, ...). I believe the supporting changes are generally useful these include: 1. Moving config files out of the root directory. This is to support the Kubernetes-style of applying an entire directory of configuration, potentially recursively (see below for an example). 1. Naming the image references we substitute around Go import paths. I find that this is a useful convention for expressing image provenance. These changes will support side-by-side development with Bazel and `ko`, until we make a judgement call on whether to remove Bazel. Here's an example of me running this locally: ```shell $ time ko apply -f config/ 2018/04/26 21:35:26 Go building github.com/elafros/eventing/cmd/controller 2018/04/26 21:35:36 Publishing us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller:latest 2018/04/26 21:35:37 mounted sha256:4fe6b1eadc150125dbdff941f6e199cef0ac6b5c37795bf7cdb263f02a05f955 2018/04/26 21:35:37 mounted sha256:eb05f3dbdb543cc610527248690575bacbbcebabe6ecf665b189cf18b541e3ca 2018/04/26 21:35:37 mounted sha256:a027959537706a82d5fcf8d13f5624b002e39b652c21ec01e787233921434f9a 2018/04/26 21:35:37 pushed us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller:latest 2018/04/26 21:35:37 Published us.gcr.io/convoy-adapter/github.com/elafros/eventing/cmd/controller@sha256:3afe5f28f3c500f7bf6d2be142cad9b75afcc2a601a3e5709277a91284fd9e15 namespace "bind-system" created customresourcedefinition "binds.eventing.elafros.dev" created clusterrolebinding "bind-controller-admin" created deployment "bind-controller" created customresourcedefinition "eventsources.eventing.elafros.dev" created customresourcedefinition "eventtypes.eventing.elafros.dev" created serviceaccount "bind-controller" created real 0m13.700s user 0m10.976s sys 0m0.864s ``` * Update the sample as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can read more about
kohere, but the tl;dr is that it is an experimental tool to replicate the current DevX with Bazel without the baggage Bazel comes with (learning curve, BUILD files, Java dependency, ...).I believe the supporting changes are generally useful these include:
These changes will support side-by-side development with Bazel and
ko, until we make a judgement call on whether to remove Bazel.Here's an example of me running this locally: