apiServerSource now retries sending events

[xinydev]

Signed-off-by: XinYang xinydev@gmail.com

Fixes #2980

Proposed Changes

• apiServerSource now retries sending events using exponential backoff, 5 times. same as PingSource

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Docs

[knative-prow-robot]

Hi @xinydev. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5457 (5f798c3) into main (262b70e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 5f798c3 differs from pull request most recent head b129ead. Consider uploading reports for the commit b129ead to get more accurate results

@@            Coverage Diff             @@
##             main    #5457      +/-   ##
==========================================
+ Coverage   82.66%   82.77%   +0.11%     
==========================================
  Files         198      197       -1     
  Lines        6171     6096      -75     
==========================================
- Hits         5101     5046      -55     
+ Misses        743      725      -18     
+ Partials      327      325       -2     

Impacted Files	Coverage Δ
pkg/adapter/apiserver/events/events.go	94.44% <100.00%> (+0.07%)	⬆️
pkg/adapter/v2/cloudevents.go	83.33% <100.00%> (+1.41%)	⬆️
pkg/kncloudevents/message_sender.go	82.25% <0.00%> (-7.40%)	⬇️
pkg/apis/duck/v1/delivery_types.go	88.23% <0.00%> (-3.44%)	⬇️
pkg/apis/duck/v1beta1/delivery_types.go	88.23% <0.00%> (-2.25%)	⬇️
pkg/reconciler/broker/trigger/trigger.go	80.45% <0.00%> (-1.87%)	⬇️
pkg/adapter/mtping/pingsource.go	38.46% <0.00%> (-1.54%)	⬇️
pkg/inmemorychannel/message_dispatcher.go	88.88% <0.00%> (-1.12%)	⬇️
pkg/apis/eventing/v1/trigger_lifecycle.go	45.00% <0.00%> (-1.04%)	⬇️
pkg/apis/eventing/v1/trigger_types.go	100.00% <0.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262b70e...b129ead. Read the comment docs.

[xinydev]

/assign @matzew
/assign @lionelvillard

[pierDipi]

Hi @xinydev, thanks for sending a PR, can we please add an E2E test for this new feature?

A useful (I think) example is

eventing/test/rekt/features/broker/source_to_sink.go

Line 179 in d1106c8

func SourceToSinkWithFlakyDLQ(brokerName string) *feature.Feature {

that uses the flaker test image https://github.com/knative/eventing/blob/d1106c89f7276d1e0cb804ea343f2fb7e53b9546/test/test_images/event-flaker/main.go

[xinydev]

/ok-to-test

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[xinydev]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@benmoss Would you please check the CLA?

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[xinydev]

/test all

[benmoss]

@googlebot I fixed it.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/apiserver/events/events.go	96.4%	96.5%	0.1

[xinydev]

/hold cancel

[lionelvillard]

/lgtm
/approve

Thanks!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, xinydev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment