Fix tests

test/conformance/helpers/channel_status_subscriber_test_helper.go

@@ -59,7 +59,7 @@ func channelHasRequiredSubscriberStatus(ctx context.Context, st *testing.T, clie
 	client.CreateChannelOrFail(channelName, &channel)
 	client.WaitForResourceReadyOrFail(channelName, &channel)
 
-	_ = recordevents.DeployEventRecordOrFail(context.TODO(), client, subscriberServiceName+"-pod")
+	_ = recordevents.DeployEventRecordOrFail(context.TODO(), client, subscriberServiceName)
 
 	subscription := client.CreateSubscriptionOrFail(
 		subscriberServiceName,

test/rekt/features/broker/readyness.go

@@ -37,9 +37,7 @@ func TriggerGoesReady(name, brokerName string) *feature.Feature {
 	// The test needs a subscriber.
 	sub := feature.MakeRandomK8sName("sub")
 	f.Setup("install a service", svc.Install(sub, "app", "rekt"))
-
-	// Point the Trigger subscriber to the service installed in setup.
-	cfg = append(cfg, trigger.WithSubscriber(svc.AsKReference(name), ""))
+	cfg = append(cfg, trigger.WithSubscriber(svc.AsKReference(sub), ""))
 
 	// Install the trigger
 	f.Setup(fmt.Sprintf("install trigger %q", name), trigger.Install(name, brokerName, cfg...))

test/rekt/features/channel/features.go

@@ -79,15 +79,17 @@ func ChannelChain(length int) *feature.Feature {
 func DeadLetterSink() *feature.Feature {
 	f := feature.NewFeature()
 	sink := feature.MakeRandomK8sName("sink")
+	failer := feature.MakeK8sNamePrefix("failer")
 	cs := feature.MakeRandomK8sName("containersource")
 	name := feature.MakeRandomK8sName("channel")
 
 	f.Setup("install sink", eventshub.Install(sink, eventshub.StartReceiver))
+	f.Setup("install failing receiver", eventshub.Install(failer, eventshub.StartReceiver, eventshub.DropFirstN(1)))
 	f.Setup("install channel", channel_impl.Install(name, delivery.WithDeadLetterSink(svc.AsKReference(sink), "")))
 	f.Setup("install containersource", containersource.Install(cs, source.WithSink(channel_impl.AsRef(name), "")))
 	f.Setup("install subscription", subscription.Install(feature.MakeRandomK8sName("subscription"),
 		subscription.WithChannel(channel_impl.AsRef(name)),
-		subscription.WithReply(svc.AsKReference("does-not-exist"), ""),
+		subscription.WithReply(svc.AsKReference(failer), ""),
 	))
 
 	f.Requirement("channel is ready", channel_impl.IsReady(name))