Roadmap updated with feedback by ultrasaurus · Pull Request #55 · knative/eventing

ultrasaurus · 2018-04-28T01:51:40Z

partially addresses #45

this addresses feedback from #46 (and fixes formatting)

I accidentally requested review when I hadn't pushed the changes!

google-prow-robot · 2018-04-28T01:51:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ultrasaurus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ultrasaurus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2018-04-28T02:21:29Z

-# 0.4
+* A. An event can trigger an Elafros function [issue#52](https://github.com/elafros/eventing/issues/52)
+* B. A local event can trigger a Google Cloud Function
+* C. A Google source can trigger a local action. Likely this will use some


Does local mean within the Elafros cluster?

Yep. Updated the wording to convey that

dprotaso · 2018-04-28T02:22:32Z

+* A. Ability to register an event sources and specify which events may be
+   generated from that source
+   [Proposal](https://github.com/elafros/eventing/issues/39)
+* B. kubctl command to set up a trigger where a specific event will cause a


imjasonh · 2018-04-28T04:06:02Z

+# 0.1 CloudEvents Demo

-# 0.2
+* A. Ability to register an event sources and specify which events may be


FWIW, if you prefix these with 1. the items will be numbered. Or * to make bullet points. e.g.,

1. foo 1. bar 1. baz

foo

bar

baz

Not sure how to make them A, B, C though.

GitHub markdown doesn't support A, B, C. I miss it terribly, but it's not going to happen.

rachelmyers · 2018-05-01T16:08:42Z

@dprotaso and @imjasonh, could we get a second look at this PR?

imjasonh

I don't have any feedback on the roadmap itself, just formatting nits and typos

imjasonh · 2018-05-01T18:00:03Z

@@ -1,22 +1,48 @@
 Eventing Roadmap


# Eventing Roadmap

imjasonh · 2018-05-01T18:00:12Z


-# 0.1
+At the end of each milestone, there should be a new or updated demo in
+the samples directory.


Link to samples directory?

simplified to link in README

imjasonh · 2018-05-01T18:00:38Z

+1. There is a well-defined interface that allows the use of popular event
+   brokers for persistence, such as Kafka and Rabbit Mq
+
+# 0.5 Piplelines


typo: Pipelines

fixed, thanks!

markfisher · 2018-05-11T02:24:03Z

+   generated from that source
+   [Proposal](https://github.com/elafros/eventing/issues/39)
+1. kubectl command to set up a trigger where a specific event will cause a
+  specific action powered by a specific processor


why is the processor abstraction needed? If the "target" is simply a URL, we could rely on all of the features of envoy (traffic policies, security, metrics, etc), and that would provide consistency with "normal" HTTP traffic via routes to apps

Sorry if the term processor is confusing... it makes sense to me to have the target be a specific URL, but also having some additional data besides the URL may help instrumentation and debugging. For now, I'll drop "powered by a specific processor" from the roadmap and we can work out the details in PRs or issues

markfisher · 2018-05-11T02:27:19Z

+
+# 0.6 Streams
+
+1. an action may accept a stream interface to process many events at once


related: knative/serving#813

interesting.... will review. Prolly too granular for the roadmap tho

markfisher · 2018-05-11T02:30:56Z

+
+# 0.5 Piplelines
+
+1. Pipeline the output of one action into the input of another


this should include (perhaps as a separate bullet point) the ability to have multiple actions downstream

should this include buffering? would it require one of the brokers mentioned in the 0.4 section?

buffering was intended to be part of 0.4 -- made that more clear

added second bullet on pipelining

ultrasaurus

addressed feedback

ultrasaurus · 2018-05-16T00:51:40Z

+   generated from that source
+   [Proposal](https://github.com/elafros/eventing/issues/39)
+1. kubectl command to set up a trigger where a specific event will cause a
+  specific action powered by a specific processor


Sorry if the term processor is confusing... it makes sense to me to have the target be a specific URL, but also having some additional data besides the URL may help instrumentation and debugging. For now, I'll drop "powered by a specific processor" from the roadmap and we can work out the details in PRs or issues

ultrasaurus · 2018-05-16T00:51:56Z


-# 0.1
+At the end of each milestone, there should be a new or updated demo in
+the samples directory.


simplified to link in README

ultrasaurus · 2018-05-16T00:52:34Z

+1. There is a well-defined interface that allows the use of popular event
+   brokers for persistence, such as Kafka and Rabbit Mq
+
+# 0.5 Piplelines


fixed, thanks!

ultrasaurus · 2018-05-16T00:56:48Z

+
+# 0.5 Piplelines
+
+1. Pipeline the output of one action into the input of another


buffering was intended to be part of 0.4 -- made that more clear

added second bullet on pipelining

ultrasaurus · 2018-05-16T01:05:05Z

+
+# 0.6 Streams
+
+1. an action may accept a stream interface to process many events at once


interesting.... will review. Prolly too granular for the roadmap tho

ultrasaurus · 2018-05-16T01:13:22Z

/assign @mogar1980 -- all feedback addressed, pls review

mogar1980 · 2018-05-16T01:17:11Z

/lgtm

ultrasaurus added 3 commits April 27, 2018 18:48

add link to CloudEvents repo

9ca8985

integrated feedback from PR comments

48f0f6a

fix formatting

330294d

google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2018

dprotaso reviewed Apr 28, 2018

View reviewed changes

imjasonh reviewed Apr 28, 2018

View reviewed changes

rachelmyers added 3 commits May 1, 2018 12:59

Bullets and letters to auto incremented numbers

88fbf36

s/kubctl/kubectl

113a57d

Specify that local is within the Elafros cluster

4a52472

imjasonh reviewed May 1, 2018

View reviewed changes

evankanderson assigned dprotaso, rachelmyers and markfisher May 3, 2018

markfisher reviewed May 11, 2018

View reviewed changes

address feedback, clarifying roadmap language + typos

5b66d11

ultrasaurus commented May 16, 2018

View reviewed changes

google-prow-robot assigned mogar1980 May 16, 2018

google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2018

google-prow-robot merged commit e3ca6e7 into knative:master May 16, 2018

csantanapr mentioned this pull request May 25, 2019

Add imagePullPolicy to ContainerSourceSpec API #1272

Closed


		# 0.6 Streams

		1. an action may accept a stream interface to process many events at once


		# 0.5 Piplelines

		1. Pipeline the output of one action into the input of another

Conversation

ultrasaurus commented Apr 28, 2018

Uh oh!

google-prow-robot commented Apr 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imjasonh Apr 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rachelmyers commented May 1, 2018

Uh oh!

imjasonh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ultrasaurus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ultrasaurus commented May 16, 2018

Uh oh!

mogar1980 commented May 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

imjasonh Apr 28, 2018 •

edited

Loading