Skip to content

Add IMC webhook the permission to update namespaces/finalizers#5539

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
aliok:fix-imc-webhook-clusterrole
Jun 22, 2021
Merged

Add IMC webhook the permission to update namespaces/finalizers#5539
knative-prow-robot merged 1 commit into
knative:mainfrom
aliok:fix-imc-webhook-clusterrole

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jun 22, 2021

Fixes #

Issues in e2e tests like https://github.com/knative/eventing/runs/2829340913#step:12:5268

Proposed Changes

Same as #5501 but for IMC, which now is a separate component with its own webhook and stuff.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

imc-controller cluster role now has update permission for namespaces/finalizers.

Docs

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jun 22, 2021

/retest

Infra

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (skip schedule deleting pod: test-pods/ef3e8b62-d338-11eb-b01a-da3ff9498687)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 22, 2021

Codecov Report

Merging #5539 (159a10e) into main (b312f0e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5539   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files         198      198           
  Lines        6125     6125           
=======================================
  Hits         5057     5057           
  Misses        741      741           
  Partials      327      327           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b312f0e...159a10e. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit 587958f into knative:main Jun 22, 2021
@aliok aliok deleted the fix-imc-webhook-clusterrole branch June 22, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants