Skip to content

[QE] Removing deprecated code from test/upgrade#5555

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
cardil:bugfix/5554-cleanup
Jun 29, 2021
Merged

[QE] Removing deprecated code from test/upgrade#5555
knative-prow-robot merged 1 commit into
knative:mainfrom
cardil:bugfix/5554-cleanup

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented Jun 28, 2021

Fixes #5554

Proposed Changes

  • 🧹 Clean up deprecated code from test/upgrade package

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 28, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2021
@cardil cardil force-pushed the bugfix/5554-cleanup branch from 8c65b47 to a1e9deb Compare June 28, 2021 11:27
@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Jun 28, 2021

/cc @zhongduo

I'm removing deprecated code - you probably will need to adjust if not done it already

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@cardil: GitHub didn't allow me to request PR reviews from the following users: zhongduo.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @zhongduo

I'm removing deprecated code - you probably will need to adjust if not done it already

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2021

Codecov Report

Merging #5555 (a1e9deb) into main (14ae489) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5555   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         198      198           
  Lines        6153     6153           
=======================================
  Hits         5084     5084           
  Misses        742      742           
  Partials      327      327           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ae489...a1e9deb. Read the comment docs.

@cardil cardil changed the title Removing deprecated code from test/upgrade [QE] Removing deprecated code from test/upgrade Jun 28, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@knative-prow-robot knative-prow-robot merged commit b2f4322 into knative:main Jun 29, 2021
@cardil cardil deleted the bugfix/5554-cleanup branch June 29, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QE] Remove all deprecated code in test/upgrade package

3 participants