Add Channels with no subscribers to config map#568
Merged
knative-prow-robot merged 1 commit intoOct 31, 2018
Conversation
If a channel has no subscribers, it should still be in the configmap. This allows the dispatcher to respond with a 202 to a publish request (then drop the published event).
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
The following is the coverage report on pkg/.
|
Contributor
|
/lgtm We agreed to add the unit test in a quick follow up. |
adamharwayne
pushed a commit
to Harwayne/knative-eventing
that referenced
this pull request
Oct 31, 2018
adamharwayne
pushed a commit
to Harwayne/knative-eventing
that referenced
this pull request
Oct 31, 2018
adamharwayne
pushed a commit
to Harwayne/knative-eventing
that referenced
this pull request
Oct 31, 2018
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a channel has no subscribers, it should still be in the configmap. This allows the dispatcher to respond with a 202 to a publish request (then drop the published event).
Release Note
/cc @adamharwayne