Add control plane services for Kafka Channel Provisioner

[neosab]

Fixes #442

Proposed Changes

• Adds the K8S Service & Virtual Service for the Channel
• Adds Dispatcher Service for the kafka ClusterChannelProvisioner

I believe this would finish the required control plane setup for Kafka channel provisioner.

Release Note

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[neosab]

/cc @adamharwayne @n3wscott @matzew

[knative-prow-robot]

@neosab: GitHub didn't allow me to request PR reviews from the following users: matzew.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @adamharwayne @n3wscott @matzew

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sebgoa]

there are a lot of howto/example like things that could live better in the docs repo IMHO.

[matzew]

@sebgoa you mean the three README files ?

we did follow the "old" model, and also the in-mem channel provisioner has some doc.

That said, once this is merged we will get also a hand on proper docs for eventing. with different chapters for different channels and sources.

IMO for the moment they live well here (or in the eventing-sources repo, e.g. see the k8sevent source demo/docs)

[sebgoa]

@sebgoa you mean the three README files ?

we did follow the "old" model, and also the in-mem channel provisioner has some doc.

I mean everything in /config/provisioners/kafka/broker and /config/provisioners/kafka/strimzi

These are not related to the provisioner, they are two ways to deploy Kakfa in k8s. I know you need a working Kafka but these are very much docs that would better live outside this code base. Either /knative/docs or simply make a reference to the upstream documentation of these projects.

Why ? as soon as these projects do an update the documentation/instructions that you are putting in here are going to be obsolete.

Also there are many different ways to deploy Kafka on k8s. Instead of strimzi, why not the confluent operator. IMHO, To avoid contention, I would simply remove it or point to the upstream docs.

[matzew]

some of that has been addressed in 468 strimzi: reference. in kafka, I agree. would be a nice chapter in docs‘ eventing book. will take a look. Thanks!

On Thu 8. Nov 2018 at 22:40, sebgoa ***@***.***> wrote: @sebgoa <https://github.com/sebgoa> you mean the three README files ? we did follow the "old" model, and also the in-mem channel provisioner has some doc. I mean everything in /config/provisioners/kafka/broker and /config/provisioners/kafka/strimzi These are not related to the provisioner, they are two ways to deploy Kakfa in k8s. I know you need a working Kafka but these are very much docs that would better live outside this code base. Either /knative/docs or simply make a reference to the upstream documentation of these projects. Why ? as soon as these projects do an update the documentation/instructions that you are putting in here are going to be obsolete. Also there are many different ways to deploy Kafka on k8s. Instead of strimzi, why not the confluent operator. IMHO, To avoid contention, I would simply remove it or point to the upstream docs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#573 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJnziIuQ0H7H6oBjrLpjyC5A2LlLp2nks5utGnKgaJpZM4YErFT> .

-- Sent from Gmail Mobile

[neosab]

I am fine with co-authoring the PR with @matzew

[matzew]

same here! fine with changes from Sabari!

On Fri 9. Nov 2018 at 20:43, Sabari Kumar Murugesan < ***@***.***> wrote: I am fine with co-authoring the PR with @matzew <https://github.com/matzew> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#573 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJnzvRIWivt8fUT-GxqTnB6cYnHVBKGks5utdr7gaJpZM4YErFT> .

-- Sent from Gmail Mobile

[neosab]

/assign @evankanderson

[evankanderson]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, neosab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/provisioners/kafka/controller/channel/reconcile.go	84.2%	79.4%	-4.8
pkg/provisioners/kafka/controller/reconcile.go	86.7%	78.9%	-7.7

[neosab]

@evankanderson Sorry need someone to reset the CLA again

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

[matzew]

/lgtm