[release-0.26] Validate DeliverySpec in Channels & Subscriptions#5778
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## release-0.26 #5778 +/- ##
================================================
+ Coverage 82.65% 82.67% +0.01%
================================================
Files 202 202
Lines 6326 6332 +6
================================================
+ Hits 5229 5235 +6
Misses 758 758
Partials 339 339
Continue to review full report at Codecov.
|
pierDipi
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/assign @travis-minke-sap
for CLA consent
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@googlebot I consent |
Co-authored-by: I867318 <travis.minke@sap.com>
Co-authored-by: I867318 <travis.minke@sap.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: I867318 <travis.minke@sap.com>
* Validate DeliverySpec in Channels & Subscriptions (knative#5778) Co-authored-by: I867318 <travis.minke@sap.com> * Default dead letter sink namespace to the object namespace Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Add unit test Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Run hack/update-codegen.sh Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: I867318 <travis.minke@sap.com>
This is an automated cherry-pick of #5777