Rename Sinkable to Addressable.

[evankanderson]

Temporarily use Addressable for Callable as well.

Fixes #542

Proposed Changes

• Rename Sinkable to Addressable, update docs.
• Rename Targetable to Callable. Currently, the interface for Callable is the same as Addressable, but we will probably use an annotation to distinguish between the two in the future.

I also re-wrapped a few lines that were folded just over 80 chars while I was fixing comments. Sorry!

Release Note

* Updates the contract for receiving events to be named Addressable.
* Updates the contract for returning events in response to a delivered event to be named Callable. This is not currently distinguished by type from Addressable.

[n3wscott]

lgtm

I want a second review, so I will let someone else let it commit.

[matzew]

this file has one more reference to Targetable:

eventing/pkg/controller/eventing/subscription/reconcile.go

Line 106 in 331bf49

return fmt.Errorf("could not get domain from subscriber (is it not targetable?)")

[matzew]

should this, and references be changed too?

eventing/pkg/controller/eventing/subscription/reconcile_test.go

Line 51 in 331bf49

sinkableDNS = "myresultchannel.mynamespace.svc.cluster.local"

[matzew]

/lgtm
/hold

added some minor comments

[vaikas]

I think we also need to update the eventing-sources repo for the sources in there?

[vaikas]

Did you run through the samples to see if they still work after this change?

[vaikas]

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [evankanderson,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment